RestIntegTestTask fails because of missed log4j-core dependency

[reta]

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

Using opensearch.yaml-rest-test Gradle plugin outside of the OpenSearch core (fe, in plugins), for example yamlRestTest, fails with the following exception:

> Task :yamlRestTest

org.opensearch.path.to.plugin.RenameClientYamlTestSuiteIT > initializationError FAILED
    java.lang.NoClassDefFoundError: org/apache/logging/log4j/core/Layout

Since the log4j-core is declared as optional, it is not being picked up. Adding it as an explicit dependency does not solve the problem either (see please opensearch-project/opensearch-plugin-template-java#16 for more details) because the task uses dedicated configuration yamlRestTestImplementation and only its dependencies.

Issues Resolved

Closes #1814

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[opensearch-ci-bot]

Can one of the admins verify this patch?

[reta]

@saratvemulapalli @dblock the root cause is clear now: the yamlRestTest uses dedicated configuration named yamlRestTestImplementation and explicitly adds only org.opensearch.test:framework. Since the log4j-core is declared as optional, it is not being picked up (outside the core builds).

[opensearch-ci-bot]

❌   Gradle Check failure def1710508c0f56511ab2d6bda20f4b85e7dcd66
Log 1695

Reports 1695

[opensearch-ci-bot]

✅   Gradle Check success 4ec9bcb
Log 1696

Reports 1696

[dblock]

There's got to be a better fix than this, but YOLO.

[reta]

There's got to be a better fix than this, but YOLO.

I think with the way the plugin is implemented right now, the fix is fine - single place where the dependencies are set up. But surely, there are other ways to fix that.