-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Startup fails with theme overrides #6704
Comments
checkout a commit older than this PR would resolve thus narrow down to this PR #5652 |
Different from the screen recording in the PR #6703 The dashboard in future playground won't display anything |
Found issue still happening, thus re-opened |
@BionIT Can you provide some repro details? If I visit https://future.playground.opensearch.org, this is what I see |
Yep, @joshuarrrr this is after switching to an older commit than the PR which introduced the bug, otherwise, we see empty page. Please check future playground for the empty page and error now. |
I just need more info to be able to debug it, so if there was a version that included #6703 and #5652, that would be really helpful, because it doesn't repro running locally. I can also provide some additional context: The issue is likely not in That means that there's likely an issue with this block of code: OpenSearch-Dashboards/src/legacy/ui/ui_render/ui_render_mixin.js Lines 174 to 177 in b5121d3
which wasn't edited, but moved in #5652 |
@BionIT same question here, is there a way to reproduce locally or could you help to add some repro steps? |
To repro:
I don't have bandwidth to look further, and I wonder if the change would behave different when it is in container? |
i think cache issue. that supercedes the cache buster for plugins. 2.13 navigate to playground/app/plugin 2.14 navigate to playground/app/plugin expected: tbh i'm not sure if this normal issue or something special about docker's caching optimization. we could consider just adding a default value to that osdThemeTag in bootstrap if window.osdThemeTag is undefined. @joshuarrrr @ananzh. |
Issue Resolve opensearch-project#6704 Signed-off-by: Anan Zhuang <ananzh@amazon.com>
reverted in 2.14 in 2.x as @joshuarrrr is addressing existing issue that got exposed by this work but not from this work. |
@joshuarrrr Do we still target this fix for 2.15 or 2.16? |
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
OpenSearch Version
Please list the version of OpenSearch being used.
Dashboards Version
Please list the version of OpenSearch Dashboards being used.
Plugins
Please list all plugins currently enabled.
Screenshots
If applicable, add screenshots to help explain your problem.
Host/Environment (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: