Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export a common URL key for plugins to check for datasource #6534

Open
derek-ho opened this issue Apr 18, 2024 · 0 comments · May be fixed by #6602
Open

Export a common URL key for plugins to check for datasource #6534

derek-ho opened this issue Apr 18, 2024 · 0 comments · May be fixed by #6602
Assignees
Labels
enhancement New feature or request v2.16.0

Comments

@derek-ho
Copy link
Contributor

Currently, the selected datasource is not a global concept. This means that each plugin has to manage its own selected datasource, which can be done either via session/local storage, internally within their react app, or via URL, which many plugins seem to be doing. This issue is to propose datasource or datasource management plugin to export a common URL key to use, such as: https://github.com/opensearch-project/security-dashboards-plugin/blob/feature/supporting-multiple-datasources/public/utils/datasource-utils.ts#L22. This key could then be used by plugins to set/read the datasource via the URL, and could help with cohesion and maintaining datasource context when navigating between plugins.

Alternatives: key for session/local storage, but this would not be able to be link shared between users/bookmarked, so I think URL is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.16.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants