Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all required dependencies specified under Windows in requirements.dev.txt #204

Open
StevenMaude opened this issue May 18, 2023 · 1 comment

Comments

@StevenMaude
Copy link
Contributor

I just tried updating all development packages, with hashes, generated in a Linux Python 3.8 install, and found that I couldn't get the Windows build on GitHub to pass.

This is because colorama is required as a dependency for build==0.9.0 (itself a pip-tools dependency) and greater in Windows, but not for Linux.

For now, without package hashes, requirements.dev.txt still installs perfectly well in the GitHub Actions CI, because pip will quite happily install other packages it needs without hashes.

Unfortunately, pip-tools doesn't have much support for generating requirements cross-platform: jazzband/pip-tools#826. Another option is just to add colorama into the requirements, but that's not great either and also would result, I think, in this issue: pypa/build#493.

@StevenMaude
Copy link
Contributor Author

Also relates to opensafely-core/repo-template#52.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant