Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully support EMIS backend #1831

Open
rebkwok opened this issue Dec 11, 2023 · 0 comments
Open

Fully support EMIS backend #1831

rebkwok opened this issue Dec 11, 2023 · 0 comments

Comments

@rebkwok
Copy link
Contributor

rebkwok commented Dec 11, 2023

#797 added the main tables to support EMIS as a backend. There is still some work to do before studies can be fully runnable in EMIS:

  • authentication
  • trino version
    • we're using a different trino base docker image in ehrQL tests to the one used in cohort-extractor. This is so we can use the memory connector in tests, but we should verify that core ehrQL functionality is consistent with the version of trino that EMIS uses (cohort-extractor is still using a presto db URL and the presto-python-client rather than trino
  • Data checks: some of the data in EMIS looks similar but different to TPP. In cohort-extractor, there appear to be some assumptions that it is the same (e.g. returning values are specified using the same names, such as nuts1_region_name, but actually contain different value ranges). Ones I noticed while working on Add an EMIS schema and backend #797 are:
    • patient_all_orgs_v2.english_region_name is used to return nuts1_region_name in cohort-extractor, but values do not match names of NUTS1 regions
    • MSOA in EMIS contains Scottish and Welsh MSOAs (although registered practices for these patients is in England)
  • Test that a minimal study can run in EMIS (this is a carry-over from Add an EMIS schema and backend #797)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant