Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish appointments-short-data-report #1688

Open
inglesp opened this issue Oct 30, 2023 · 3 comments
Open

Publish appointments-short-data-report #1688

inglesp opened this issue Oct 30, 2023 · 3 comments
Assignees
Milestone

Comments

@inglesp
Copy link
Contributor

inglesp commented Oct 30, 2023

From Seb:

This is a short data report about Appointments. We link to it from our documentation. However, it is not published.

Given our "working in the open" principle, it is something of a smell to publish a link to a non-public document.

We should publish the report, with a disclaimer added at the top. This Database Coverage report has good text we could copy as frontmatter:

This report displays the historical coverage of the OpenSAFELY-TPP database. It is part of the OpenSAFELY platform's technical documentation and is published at https://reports.opensafely.org/.

This report should not be used for inference about any aspect of the pandemic, public health, or health service activity. For the avoidance of doubt, any clinical or epidemiological interpretation of this report is likely to be a misinterpretation.

If you would like to use the OpenSAFELY platform, then you should read our documentation, our principles, and our process for onboarding new users. If you would like to see the code we used to create this report, then you can view it on GitHub.

@inglesp inglesp added this to the P1 Deprecate cohort-extractor milestone Oct 30, 2023
@inglesp
Copy link
Contributor Author

inglesp commented Oct 30, 2023

See opensafely/appointments-short-data-report#43 for implementation notes.

iaindillingham added a commit that referenced this issue Nov 8, 2023
Doing so should give the reader enough information to decide whether to
click the link, login to OpenSAFELY Jobs, and (possibly) request a
suitable role for the project (although see #1688).

Closes #1638
@iaindillingham
Copy link
Member

iaindillingham commented Nov 9, 2023

TODO

  • Suppress counts. (The disclosure control guidance was updated.)
  • Ask an output reviewer to look at analysis/reports/report.ipynb (For the same reason. Would they make a small exception?)1
  • Fix failure when run locally (and presumably in CI)
  • Handle T1OOs
  • Check Operations Group approval
  • Check NHSE approval
  • Update jobserver permissions
  • Run on OS Jobs
  • Request outputs are checked

Footnotes

  1. https://bennettoxford.slack.com/archives/C01UJLWNZJT/p1699884698368099

@iaindillingham iaindillingham changed the title Publish short data report on Appointments Publish appointments-short-data-report Nov 10, 2023
@iaindillingham
Copy link
Member

iaindillingham commented Nov 13, 2023

I've moved this to "blocked" because:

  • It's unclear whether this report has Operations Group approval.1
  • It's unclear whether this report is exempt from NHSE approval.2 Amir has argued that short data reports are exempt, but that we should nevertheless contact NHSE as a courtesy.
  • The project that's associated with this workspace doesn't have permission to run SQL Runner actions. A member of the IG team must grant this permission.3

Footnotes

  1. https://bennettoxford.slack.com/archives/C01UJLWNZJT/p1699885642360359

  2. https://bennettoxford.slack.com/archives/C31D62X5X/p1686742702816139?thread_ts=1686669958.929239&cid=C31D62X5X

  3. https://bennettoxford.slack.com/archives/C63UXGB8E/p1699887531231189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Blocked
Development

No branches or pull requests

2 participants