Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from DockerComposeContainer to ComposeContainer #436

Open
eddumelendez opened this issue Nov 28, 2023 · 1 comment
Open

Move from DockerComposeContainer to ComposeContainer #436

eddumelendez opened this issue Nov 28, 2023 · 1 comment
Labels
good first issue Good for newcomers recipe Recipe request testcontainers

Comments

@eddumelendez
Copy link
Collaborator

What problem are you trying to solve?

Move from Compose V1 to Compose V2 support

What precondition(s) should be checked before applying this recipe?

org.testcontainers.containers.DockerComposeContainer is used.

Describe the situation before applying the recipe

import org.testcontainers.containers.DockerComposeContainer;

class A {
    void foo(String bar) {
        DockerComposeContainer compose = new DockerComposeContainer();
    }
}

Describe the situation after applying the recipe

import org.testcontainers.containers.ComposeContainer;

class A {
    void foo(String bar) {
        ComposeContainer compose = new ComposeContainer();
    }
}

Have you considered any alternatives or workarounds?

Any additional context

Are you interested in contributing this recipe to OpenRewrite?

@timtebeek
Copy link
Contributor

See this comment for a likely sufficient approach

@timtebeek timtebeek added the good first issue Good for newcomers label Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers recipe Recipe request testcontainers
Projects
Status: Recipes Wanted
Development

No branches or pull requests

2 participants