Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mockito 3 to 4 migration #186

Closed
pway99 opened this issue Jan 26, 2022 · 4 comments
Closed

Add Mockito 3 to 4 migration #186

pway99 opened this issue Jan 26, 2022 · 4 comments
Labels
recipe Recipe request
Projects
Milestone

Comments

@pway99 pway99 added the enhancement New feature or request label Jan 26, 2022
@pway99 pway99 added this to Icebox in Backlog via automation Jan 26, 2022
@pway99 pway99 mentioned this issue Jan 26, 2022
@tkvangorder tkvangorder added recipe Recipe request and removed enhancement New feature or request labels Apr 19, 2022
@timtebeek
Copy link
Contributor

There have been a few more releases since this issue was opened; Mockito is now at 4.7.0.
4.0.0 dropped a number of deprecated APIs; which are already covered in the 3.x migration.

The only other deprecation since was in 4.5.0 with Listutil and Fields classes, but both of these classes were in org.mockito.internal.util, so not part of the public API.

That means that for now at least there are no further required steps (apart from the dependency) to upgrade to 4.7.0, with any next required migration steps likely to roll over into a 5.x migration.

There's already a placeholder 4.x migration, which might only need a dependency version upgrade, which might not even need a pull request.

@pway99 pway99 closed this as completed in 184a076 Aug 30, 2022
@pway99
Copy link
Contributor Author

pway99 commented Aug 30, 2022

Thanks Tim! I renamed the existing Mockito3To4Migration to Mockito1To4Migration`since the recipe already referenced the 1To3Migration. I also added a Maven Dependency upgrade for Mockito 4.x and updated the JUnit 4To5 reference.

@timtebeek
Copy link
Contributor

Great to see this one resolved. Should be nice to see the 4.x line picked up.:)

@pway99
Copy link
Contributor Author

pway99 commented Aug 30, 2022

For sure, thanks again for your help :)

@tkvangorder tkvangorder added this to the 1.27.0 milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recipe Recipe request
Projects
Archived in project
Backlog
  
Icebox
Development

No branches or pull requests

3 participants