From 3702f4ff3d8f3c7e5a84bb845dfb4dcaa5ea2bb2 Mon Sep 17 00:00:00 2001 From: Seraphina Orsini Date: Tue, 12 Oct 2021 12:02:55 -0400 Subject: [PATCH] Pin create-next-app to eslint@v7 (#29837) Fixes https://github.com/vercel/next.js/issues/29770 ## Description Pins `eslint` to `v7`. This avoids issues with `v8` from both [changes to the public api](https://eslint.org/docs/8.0.0/user-guide/migrating-to-8.0.0#the-lib-entrypoint-has-been-removed) and [lack of support from rushstack](https://github.com/microsoft/rushstack/issues/2890). See https://github.com/vercel/next.js/issues/29770#issuecomment-940636627 for slightly more detail. Local testing showed output of next app correctly pinned to `v7`. Screen Shot 2021-10-12 at 12 31 56 AM ### Bug Checklist - [X] Related issues linked using `fixes #number` - [ ] Integration tests added - Happy to add an integration test for pinning to v7 if we'd like, will need to be updated / removed when v8 is supported. - [ ] Errors have helpful link attached, see `contributing.md` - No errors to add links for --- create-app.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/create-app.ts b/create-app.ts index eb7c0cf..246d333 100644 --- a/create-app.ts +++ b/create-app.ts @@ -230,7 +230,7 @@ export async function createApp({ /** * Default devDependencies. */ - const devDependencies = ['eslint', 'eslint-config-next'] + const devDependencies = ['eslint@7', 'eslint-config-next'] /** * TypeScript projects will have type definitions and other devDependencies. */