Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading browser built in JSDom environment #1518

Merged
merged 4 commits into from May 12, 2022

Conversation

larabr
Copy link
Collaborator

@larabr larabr commented May 9, 2022

JSDom simulates a browser environment in node, so we shouldn't rely on runtime detection of Node .

@larabr larabr requested a review from twiss May 9, 2022 15:02
Copy link
Member

@twiss twiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, one nitpick:

src/util.js Outdated Show resolved Hide resolved
Co-authored-by: Daniel Huigens <d.huigens@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants