New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config.rejectPublicKeyAlgorithms
#1264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excellent! |
twiss
reviewed
Mar 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks, looks good! Small nitpicks below 😊
larabr
force-pushed
the
algo-blacklist
branch
3 times, most recently
from
March 15, 2021 12:56
292d04f
to
2f04938
Compare
twiss
reviewed
Mar 18, 2021
twiss
reviewed
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
config.rejectPublicKeyAlgorithms
to disallow using the given algos to verify, sign or encrypt new messages or third-party certificationsconfig.minRsaBits
when signing, verifying and encrypting messages and third-party certifications, not just on key generationsignature
will havesignature.valid=false
(used to besignature.valid=null
).signature.error
will detail whether the key is missing/too weak/other.Generating and verifying key certification signatures is still permitted in all cases.