[v5] Explicit algorithm parameter in openpgp.generateKey #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larabr
commented
Nov 14, 2020
twiss
reviewed
Nov 16, 2020
larabr
commented
Nov 17, 2020
larabr
commented
Nov 17, 2020
larabr
commented
Nov 17, 2020
larabr
force-pushed
the
algo-key-generation
branch
2 times, most recently
from
403bad7
to
a54c160
Compare
twiss
reviewed
Nov 19, 2020
twiss
reviewed
Dec 8, 2020
larabr
force-pushed
the
algo-key-generation
branch
2 times, most recently
from
d91b197
to
351e673
Compare
twiss
reviewed
Dec 9, 2020
larabr
force-pushed
the
algo-key-generation
branch
2 times, most recently
from
78408e6
to
84a2797
Compare
larabr
force-pushed
the
algo-key-generation
branch
from
84a2797
to
c67a159
Compare
larabr
force-pushed
the
algo-key-generation
branch
from
c67a159
to
d1605b0
Compare
larabr
added a commit
that referenced
this pull request
Jan 13, 2021
- Changes `openpgp.generateKey` to accept an explicit `type` parameter, instead of inferring its value from the `curve` or `rsaBits` params - Introduces `config.minRsaBits` to set minimum key size of RSA key generation
larabr
added a commit
that referenced
this pull request
Jan 13, 2021
- Changes `openpgp.generateKey` to accept an explicit `type` parameter, instead of inferring its value from the `curve` or `rsaBits` params - Introduces `config.minRsaBits` to set minimum key size of RSA key generation
twiss
pushed a commit
that referenced
this pull request
Jan 20, 2021
- Changes `openpgp.generateKey` to accept an explicit `type` parameter, instead of inferring its value from the `curve` or `rsaBits` params - Introduces `config.minRsaBits` to set minimum key size of RSA key generation
twiss
pushed a commit
that referenced
this pull request
Jan 24, 2021
- Changes `openpgp.generateKey` to accept an explicit `type` parameter, instead of inferring its value from the `curve` or `rsaBits` params - Introduces `config.minRsaBits` to set minimum key size of RSA key generation
twiss
pushed a commit
that referenced
this pull request
Feb 9, 2021
- Changes `openpgp.generateKey` to accept an explicit `type` parameter, instead of inferring its value from the `curve` or `rsaBits` params - Introduces `config.minRsaBits` to set minimum key size of RSA key generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typeparameter, instead of inferring its value from thecurveorrsaBitsparamsconfig.minRsaBitsto set minimum key size of RSA key generation