Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not getSigningKey with "keyFlags(Certify)" to sign other's key #1601

Open
snowyu opened this issue Feb 21, 2023 · 1 comment
Open

Can not getSigningKey with "keyFlags(Certify)" to sign other's key #1601

snowyu opened this issue Feb 21, 2023 · 1 comment

Comments

@snowyu
Copy link

snowyu commented Feb 21, 2023

The current getSigningKey method only returns the key that has keyFlags set to signData.

It is recommended to add the keyFlags option to the config parameter.

@twiss
Copy link
Member

twiss commented Feb 21, 2023

Hey 👋 Certifications are usually signed by the primary key. Key certifications signed by subkeys are poorly supported by most OpenPGP implementations. So, I don't think we need a keyFlags parameter for getSigningKey, rather we should change this to always use the primary key for certifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants