Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadableStream is no longer overwritten in OpenPGP.js >= 5? #1566

Open
nwtgck opened this issue Sep 18, 2022 · 3 comments
Open

ReadableStream is no longer overwritten in OpenPGP.js >= 5? #1566

nwtgck opened this issue Sep 18, 2022 · 3 comments

Comments

@nwtgck
Copy link

nwtgck commented Sep 18, 2022

Thank you so much for the great library. It helps me a lot.

The current README.md says as follows.

Please note that in those browsers, the global ReadableStream property gets overwritten with the polyfill version if it exists.

https://github.com/openpgpjs/openpgpjs/tree/d0be98feb9ab3ca3a7e22e04d0603e39bf762bcb#platform-support

However, the 5.0.0 release note says as follows.

The web-streams-polyfill and web-streams-adapter libraries are only loaded when streaming is used, and only if TransformStreams aren't natively supported

https://github.com/openpgpjs/openpgpjs/releases/tag/v5.0.0

So I guess ReadableStream is no longer overrwitten in 5. I confirmed not overwritten in Firefox ESR 91 in which previously it is overwritten. Could we update the document?

@twiss
Copy link
Member

twiss commented Sep 19, 2022

Hey 👋 Yes, you're right, the document is outdated, thanks for catching that. Do you feel like making a PR, by any chance?

@nwtgck
Copy link
Author

nwtgck commented Sep 20, 2022

Hi!
I think the maintainers are the best people to maintain the own documents. But if noone do that, I'll make it.

@larabr
Copy link
Collaborator

larabr commented Sep 20, 2022

This will likely get fixed sooner if you make a PR 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants