Throw on empty passphrase in encryptKey
and SecretKeyPacket.encrypt
#1508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change:
openpgp.encryptKey
will now throw if an empty string is given as passphrase. The operation used to succeed, but the resulting key was left in an inconsistent state, and e.g. serialization would not be possible.Non-breaking changes:
options.passphrase
ingenerateKey
andreformatKey
now defaults toundefined
instead of''
. Passing''
will not throw for now, but this might change in the future to align with theencryptKey
behaviour.GenerateKeyOptions
as alias ofKeyOptions
, to clarify its scope.