Add support for constant-time decryption of PKCS#1 v1.5-encoded session keys #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larabr
commented
Dec 1, 2021
| @@ -473,11 +476,14 @@ async function nodeDecrypt(data, n, e, d, p, q, u) { | |||
| try { | |||
| return new Uint8Array(nodeCrypto.privateDecrypt(key, data)); | |||
| } catch (err) { | |||
| if (randomPayload) { | |||
There was a problem hiding this comment.
This is not ideal, but I don't think we can do better than this
twiss
reviewed
Dec 1, 2021
Co-authored-by: Daniel Huigens <d.huigens@protonmail.com>
twiss
reviewed
Dec 2, 2021
twiss
approved these changes
Dec 2, 2021
This was referenced Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement optional constant-time decryption flow to hinder Bleichenbacher-like attacks against RSA- and ElGamal public-key encrypted session keys.
Changes:
config.constantTimePKCS1Decryptionto enable the constant-time processing (defaults tofalse). The constant-time option is off by default since it has measurable performance impact on message decryption, and it is only helpful in specific application scenarios (more info below).config.constantTimePKCS1DecryptionSupportedSymmetricAlgorithms(defaults to the AES algorithms). The set of supported ciphers is restricted by default since the number of algorithms negatively affects performance.Bleichenbacher-like attacks are of concern for applications where both of the following conditions are met: