Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update web stream tools and improve performance #1439

Merged
merged 2 commits into from Nov 17, 2021
Merged

Update web stream tools and improve performance #1439

merged 2 commits into from Nov 17, 2021

Conversation

twiss
Copy link
Member

@twiss twiss commented Nov 12, 2021 •
edited

Fix #1424

@twiss
Copy link
Member Author

twiss commented Nov 12, 2021

This PR improves performance at the cost of somewhat increased memory usage, so the memory regression test failure is somewhat expected. Decreasing memory usage (without decreasing performance again 😅) will requite more work, I will look into that separately.

@twiss twiss requested a review from larabr November 12, 2021 17:10
@twiss twiss merged commit 1d2093a into openpgpjs:master Nov 17, 2021
@twiss twiss deleted the web-stream-tools-perf branch November 17, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larabr larabr larabr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance Issue During Signature Verification
2 participants
@twiss @larabr