Prevent adding subkeys that use blacklisted curves #1423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change:
when generating new subkeys through
key.addSubkey()
, we now checkconfig.rejectCurves
and prevent adding subkeys using the corresponding curves.By default,
config.rejectCurves
includes the brainpool curves (brainpoolP256r1
,brainpoolP384r1
,brainpoolP512r1
) and the Bitcoin curve (secp256k1
).This is a follow up to #1395 , which introduced the same check to
openpgp.generateKey
.