Add config.allowInsecureVerificationWithReformattedKeys
#1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiss
approved these changes
Oct 18, 2021
larabr
added a commit
to ProtonMail/pmcrypto
that referenced
this pull request
Oct 22, 2021
To avoid rendering old messages unverifiable (see openpgpjs/openpgpjs#1422).
This was referenced Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
openpgp.reformatKeywith the defaultdateoption would render messages signed with the original key unverifiable by OpenPGP.js v5 (not v4), since the signing key would not be considered valid at the time of signing (due to its self-certification signature being in the future, compared to the message signature creation time).This PR adds
config.allowInsecureVerificationWithReformattedKeys(false by default) to make it possible to still verify such messages with the reformatted key provided the key is valid at thedatespecified for verification (which defaults to the current time).To avoid this type of issue with message verification, we recommend to pass the key creation time as
datewhen usingreformatKey.