Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add memory usage regression monitoring for pull requests #1415

Merged
merged 7 commits into from Oct 15, 2021

Conversation

larabr
Copy link
Collaborator

@larabr larabr commented Sep 9, 2021

Fix #403 : add tests to monitor memory usage of message encryption and decryption. Each test is run in a separate V8 instance, to make the result as deterministic as possible (streaming tests give false positives from time to time, but these should be easy to verify by re-running the workflow).
The tests are run on pull requests:

  • if the peak memory usage (RSS) is 2% worse than the master branch, an alert comment will be left on the PR commit.
  • if the peak memory usage (RSS) is 10% worse, the workflow will fail.

For example workflow behaviour and alert comments, see: larabr@a628975 and larabr#4

TODO:

@larabr larabr requested a review from twiss September 9, 2021 10:40
@larabr larabr marked this pull request as draft September 9, 2021 10:43
@larabr larabr marked this pull request as ready for review October 15, 2021 12:43
@larabr larabr merged commit b7527f7 into openpgpjs:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate how to monitor memory usage and implement a unit test for it
2 participants