Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config.rejectPublicKeyAlgorithms missing from @types/openpgp #1380

Closed
LucasLongarini opened this issue Jul 19, 2021 · 3 comments · Fixed by #1385
Closed

config.rejectPublicKeyAlgorithms missing from @types/openpgp #1380

LucasLongarini opened this issue Jul 19, 2021 · 3 comments · Fixed by #1385
Labels
TypeScript

Comments

@LucasLongarini
Copy link
Contributor

  • OpenPGP.js version: 5.0.0-3
  • @types/openpgp version: 4.4.17
  • Affected platform (Browser or Node.js version): Node v12.22.3

The parameter rejectPublicKeyAlgorithms on the config type is missing
@larabr
Copy link
Collaborator

larabr commented Jul 19, 2021

Hi @LucasLongarini , good point, we are actually missing all the config.reject* properties, and probably more. PR welcome :)

FYI v5 doesn't use @types/openpgp anymore, the definitions are in https://github.com/openpgpjs/openpgpjs/blob/master/openpgp.d.ts .

@LucasLongarini
Copy link
Contributor Author

PR: #1385

@larabr
Copy link
Collaborator

larabr commented Jul 23, 2021

Thanks @LucasLongarini :)

@larabr larabr closed this as completed Jul 23, 2021
@larabr larabr mentioned this issue Jul 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
TypeScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added missing config options to the TypeScript type definitions
2 participants
@larabr @LucasLongarini