From 03fa68dbb6c60f9a0bd319900eca442bad51c722 Mon Sep 17 00:00:00 2001 From: larabr Date: Thu, 18 Nov 2021 14:24:16 +0100 Subject: [PATCH] CI: create annotations on performance regression warnings/errors (#1441) --- .github/workflows/benchmark.yml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index f855e32b0..cb2b8de49 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -39,26 +39,29 @@ jobs: uses: openpgpjs/github-action-pull-request-benchmark@v1 with: tool: 'benchmarkjs' - name: 'time benchmark' + name: 'Time benchmark' pr-benchmark-file-path: pr/benchmarks.txt base-benchmark-file-path: master/benchmarks.txt github-token: ${{ secrets.GITHUB_TOKEN }} # trigger alert comment if 1.3 times slower alert-threshold: '130%' - comment-on-alert: true + comment-on-alert: false # fail workdlow if 1.5 times slower fail-threshold: '150%' fail-on-alert: true + file-to-annotate: ${{ github.workspace }}/test/benchmarks/time.js - name: Compare memory usage benchmark result uses: openpgpjs/github-action-pull-request-benchmark@v1 with: tool: 'raw' - name: 'memory usage benchmark' + name: 'Memory usage benchmark' pr-benchmark-file-path: pr/memory_usage.txt base-benchmark-file-path: master/memory_usage.txt github-token: ${{ secrets.GITHUB_TOKEN }} alert-threshold: '102%' - comment-on-alert: true + comment-on-alert: false fail-threshold: '110%' fail-on-alert: true + file-to-annotate: ${{ github.workspace }}/test/benchmarks/memory_usage.js +