Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle APP_SIGNUP_ENABLED=true setup with no working MAIL_* config #855

Open
schu opened this issue May 2, 2024 · 1 comment
Open

Handle APP_SIGNUP_ENABLED=true setup with no working MAIL_* config #855

schu opened this issue May 2, 2024 · 1 comment
Labels
bug Something isn't working enhancement New feature or request undecided

Comments

@schu
Copy link
Member

schu commented May 2, 2024

If administrators have enabled user sign-up with APP_SIGNUP_ENABLED=true but don't have a working MAIL_* configuration, new users can register and the user will be created, but the backend will encounter an Internal server error on attempt to send the verification mail and consequently the new user doesn't have a way to verify their mail address (as they didn't receive a mail with a verification link).

[2024-05-02 18:18:29] production.ERROR: An email must have a "From" or a "Sender" header. {"exception":"[object] (Symfony\\Component\\Mime\\Exception\\LogicException(code: 0): An email must have a \"From\" or a \"Sender\" header. at /var/www/openmultiplechoice/vendor/symfony/mime/Message.php:138)
[stacktrace]
#0 /var/www/openmultiplechoice/vendor/symfony/mime/Email.php(414): Symfony\\Component\\Mime\\Message->ensureValidity()
#1 /var/www/openmultiplechoice/vendor/symfony/mailer/SentMessage.php(33): Symfony\\Component\\Mime\\Email->ensureValidity()
#2 /var/www/openmultiplechoice/vendor/symfony/mailer/Transport/AbstractTransport.php(68): Symfony\\Component\\Mailer\\SentMessage->__construct()
[...]

I'm undecided whether we should support installations without working mail setup (i.e. over a different flow for this scenario) or if we should expect it (we should document the requirement, then). I'm leaning towards the latter.

@schu schu added bug Something isn't working enhancement New feature or request undecided labels May 2, 2024
@levinuss
Copy link
Contributor

levinuss commented May 2, 2024

I'm undecided whether we should support installations without working mail setup (i.e. over a different flow for this scenario) or if we should expect it (we should document the requirement, then). I'm leaning towards the latter.

Also leaning towards the latter (not supporting it and documenting that requirement).
I think public signup should not be possible without a mail setup as other verification methods are complicated (to implement and work with).
IMHO a manual user creation by admins (to be implemented) could work without a mail setup and could be enough for small instances that do not have access to a mail server/provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request undecided
Projects
None yet
Development

No branches or pull requests

2 participants