Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api/QuestionController: improve updating of answerChoices #575

Open
schu opened this issue May 21, 2023 · 0 comments
Open

Api/QuestionController: improve updating of answerChoices #575

schu opened this issue May 21, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@schu
Copy link
Member

schu commented May 21, 2023

// Update all answer choices for this question as the correct
// answer could have been changed
$answerChoices = AnswerChoice::where('question_id', '=', $question->id)->get();
foreach ($answerChoices as $answerChoice) {
$answerChoice->is_correct = $answerChoice->answer_id == $question->correct_answer_id;
$answerChoice->save();
}

This can quickly be thousands of objects and updates for frequently answered questions. Instead, use a query and let the database do the work.

@schu schu added the bug Something isn't working label May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant