Fix build index #14402
Merged
Fix build index #14402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-14402--ol-site.netlify.app/. |
|
If someone wants to create a new patch release with this fix, please go ahead. I won't be available for the next 8 hours or so. |
tschaub
approved these changes
Dec 22, 2022
|
Thanks, @tschaub. Creating a patch release now. |
|
Great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14401.
The previous fix in #14398 did not restore all of the full build. It looks like I got the old taffydb query wrong there. Going back in the history of that file, it looks like we use
doc.definein the other conditions anyway, so there should not be a need to filter out docs wheredefineis not set.