Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: potential leak in retry.go #425

Closed
hhheiaenia opened this issue May 28, 2023 · 4 comments
Closed

Bug: potential leak in retry.go #425

hhheiaenia opened this issue May 28, 2023 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@hhheiaenia
Copy link

What happened?

I notice the ctx.Done() needs a cancel function to unblock the statement of ctx.Done in https://github.com/OpenIMSDK/Open-IM-Server/blob/main/pkg/tools/retry/retry.go#LL162C20-L162C20,
but I never find the cancel function in its invocation. So if this may leak the goroutine where the ctx.Done() locates?

Maybe what I said is not right, thank you for taking a look.

What did you expect to happen?

.

How can we reproduce it (as minimally and precisely as possible)?

.

Anything else we need to know?

.

version

```console $ {name} version # paste output here ```

Cloud provider

OS version

```console # On Linux: $ cat /etc/os-release # paste output here $ uname -a # paste output here # On Windows: C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture # paste output here ```

Install tools

@kubbot kubbot changed the title Bug: Bug: May 28, 2023
Copy link
Contributor

cubxxw commented May 28, 2023

Can you add more descriptive information, such as a complete title?

@hhheiaenia hhheiaenia changed the title Bug: Bug: potential leak in retry.go Jun 1, 2023
@hhheiaenia
Copy link
Author

@cubxxw cubxxw added the kind/bug Categorizes issue or PR as related to a bug. label Jun 1, 2023
@kubbot
Copy link
Member

kubbot commented Aug 1, 2023

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@kubbot kubbot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 1, 2023
@kubbot
Copy link
Member

kubbot commented Aug 8, 2023

This issue was closed because it has been stalled for 7 days with no activity.

@kubbot kubbot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2023
luhaoling added a commit to luhaoling/open-im-server that referenced this issue Mar 5, 2024
* fix: fix the component check logic

* fix: add graceful_exit in admin-api

* fix: fix the graceful exit logic

* fix: add rpc graceful logic

* fix: del the http port

* fix: add graceful logic in chat-api

* fix: update the func location

* Before starting the script, first check if the program has exited

* fix: fix the error

* fix: fix the error

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* fix: test the func loc

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* fix: fix the tools version

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* Before starting the script, first check if the program has exited

* ComponentCheck timeout

* component check timeout

* fix: update the component check

* fix: update the component check logic

* component check timeout

* component check

* component check

* component check

* component check

* component check

* component check

* component check

* component check

* component check

* component check

* component check

* component check

* component check

* component check

* component check

* component check

* component check

* component check

---------

Co-authored-by: luhaoling <2198702716@qq.com>
Co-authored-by: Brabem <69128477+luhaoling@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants