Add support for running openHAB with Java 17 #1316

wborn · 2021-09-19T07:28:27Z

Java 17 was released on September 14th. This is a LTS release, so we should also support using it with openHAB.

This issue keeps track of what still needs to be fixed or investigated:

Upgrade Karaf to 4.3.3 (Upgrade to Karaf 4.3.3 #1315)
Zulu 32-bit ARM Java 17 JDK does not yet exist (see Downloads)
Fix rules stay uninitialized (Fix rules stay uninitialized when using Java 17 openhab-core#2787)
Upgrade Xtext/Xtend (Upgrade Xtext/Xtend to 2.26.0, LSP4J to 0.12.0 openhab-core#2786, Java 17 Masterplan, Part I eclipse/xtext#1982)
Fix XStream issues? (How much longer for XStream? x-stream/xstream#262)
Fix/suppress "A terminally deprecated method in java.lang.System has been called" warnings (KARAF-7394, Eclipse bug 574729)
Add JSScripting (Nashorn) to openhab-addons ([jsscriptingnashorn] JavaScript Scripting Nashorn Automation openhab-addons#14013)
Fix Blockly Nashorn dependency (Migrate Blockly to JS Scripting (GraalJS) openhab-webui#1597)
Fix [transform.javascript] Nashorn dependency is unavailable since Java 15 openhab-addons#12359
with Add a generic script transformation openhab-core#2883
and Introduce a profile for the generic SCRIPT transformation openhab-core#3292 and Allow inline scripts in SCRIPT transformation openhab-core#3249

openhab-bot · 2021-09-19T07:32:00Z

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-and-future-jdk-versions-when/65572/43

wborn · 2021-09-19T08:32:03Z

The runtime seems to start with Java 17 🙂, but as expected DSL rules don't work:

[ERROR] [re.automation.internal.RuleEngineImpl] - Failed to execute rule ‘demo-8' with status 'UNINITIALIZED'

It's probably due to this exception:

[DEBUG] [.access.reflect.ReflectionTypeFactory] - class org.eclipse.xtext.common.types.access.reflect.ReflectionTypeFactory cannot access interface jdk.internal.util.random.RandomSupport$RandomGeneratorProperties (in module java.base) because module java.base does not export jdk.internal.util.random to unnamed module @1d03e645
java.lang.IllegalAccessException: class org.eclipse.xtext.common.types.access.reflect.ReflectionTypeFactory cannot access interface jdk.internal.util.random.RandomSupport$RandomGeneratorProperties (in module java.base) because module java.base does not export jdk.internal.util.random to unnamed module @1d03e645
	at jdk.internal.reflect.Reflection.newIllegalAccessException(Reflection.java:392) ~[?:?]
	at java.lang.reflect.AccessibleObject.checkAccess(AccessibleObject.java:674) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:560) ~[?:?]
	at org.eclipse.xtext.common.types.access.reflect.ReflectionTypeFactory.createAnnotationReference(ReflectionTypeFactory.java:204) ~[bundleFile:?]
	at org.eclipse.xtext.common.types.access.reflect.ReflectionTypeFactory.createAnnotationValues(ReflectionTypeFactory.java:190) ~[bundleFile:?]
	at org.eclipse.xtext.common.types.access.reflect.ReflectionTypeFactory.createType(ReflectionTypeFactory.java:164) ~[bundleFile:?]
	at org.eclipse.xtext.common.types.access.reflect.ReflectionTypeFactory.createType(ReflectionTypeFactory.java:84) ~[bundleFile:?]
	at org.eclipse.xtext.common.types.access.impl.ClassMirror.initialize(ClassMirror.java:55) ~[bundleFile:?]

As a result "Rule DSL" also doesn't show as an option when adding rules via the UI.

Because Nashorn was removed in Java 15, ECMAScript also doesn't show. It might still be possible to create an Automation add-on using nashorn-core for backwards compatibility and if GraalVM is not available for your architecture, see also: https://github.com/openjdk/nashorn .

J-N-K · 2022-01-04T14:16:55Z

Regarding XStream: I'm not too confident we'll see a Java 17 implementation anytime soon (in contrast to XText where at least a roadmap exists). Maybe a change to Jakarta XML Binding 3 should be considered. There are already some addons using JAXB 2.x (while some others use XStream), so this could be unified, too.

Flole998 · 2022-02-12T00:51:00Z

@wborn Seems like Azul has published an armhf version now, so I think you can mark that as completed.

wborn · 2022-02-20T11:39:08Z

Regarding XStream: I'm not too confident we'll see a Java 17 implementation anytime soon (in contrast to XText where at least a roadmap exists).

I haven't seen any XStream issues so far with my distro builds on Java 17. Only when running unit tests there were some:

com.thoughtworks.xstream.converters.ConversionException: 
No converter available
---- Debugging information ----
message             : No converter available
type                : java.util.Collections$UnmodifiableRandomAccessList
converter           : com.thoughtworks.xstream.converters.reflection.ReflectionConverter
message[1]          : Unable to make field private static final long java.util.Collections$UnmodifiableCollection.serialVersionUID accessible: module java.base does not "opens java.util" to unnamed module @5b6fe39e
-------------------------------
	at org.openhab.core.config.xml.util.XmlDocumentReaderTest.defaultSecurityAllowsDeserializingOHCobjects(XmlDocumentReaderTest.java:70)

It looks like the add-opens workaround most issues. So I've also added them to fix similar issues for the unit tests in openhab/openhab-core#2788.

I also saw similar issues with Gson deserialization in tests. Upgrading to Gson 2.9.0 fixed the issues I ran into (Fix failing to serialize Collection or Map with inaccessible constructor), as well as the add-opens workaround.

wborn · 2022-02-20T11:56:39Z

There are also some new annoying warnings we might want to look into. 🙄

You'll see this on startup:

WARNING: A terminally deprecated method in java.lang.System has been called
WARNING: System::setSecurityManager has been called by org.eclipse.osgi.internal.framework.SystemBundleActivator (file:runtime/system/org/eclipse/platform/org.eclipse.osgi/3.16.300/org.eclipse.osgi-3.16.300.jar)
WARNING: Please consider reporting this to the maintainers of org.eclipse.osgi.internal.framework.SystemBundleActivator
WARNING: System::setSecurityManager will be removed in a future release

Similar warnings are printed when SAT runs Spotbugs on Java 17. See: spotbugs/spotbugs#1579

J-N-K · 2022-02-20T17:43:32Z

@wborn XStream: That's good to hear. I just read the issue you linked above and it seems to be an issue. Probably we don't have private final fields in objects we serialize/deserialize.

wborn · 2022-04-02T23:01:42Z

Because Nashorn was removed in Java 15, ECMAScript also doesn't show. It might still be possible to create an Automation add-on using nashorn-core for backwards compatibility and if GraalVM is not available for your architecture, see also: https://github.com/openjdk/nashorn .

I've created a JSScripting (Nashorn) add-on using the standalone Nashorn Engine which can be installed using the Marketplace.

J-N-K · 2022-04-03T07:14:28Z

That (together with openhab/openhab-core#2883) and the next release of KARAF all issues seem to be resolved.

wborn · 2022-04-03T11:16:50Z

Yes your transformation PRs look very promising! 👍 I plan on testing them soon. 🙂 Do you know if multiple JS scripting engines are also supported by the script transformation/profile in case users are still migrating between engines?

J-N-K · 2022-04-03T11:21:36Z

Yes, it should, because they use different mime-types. The nashorn engine uses application/javascript and the Graal engine uses application/javascript;version=ECMAScript-2021, so depending on what is set as script-type, one of these will be selected.

* Syncs distro customizations with Karaf 4.3.7 * Resolves app runbundles for the new dependencies For release notes, see: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311140&version=12351181 This fixes warnings when starting the runtime with Java 17 (openhab#1316). Signed-off-by: Wouter Born <github@maindrain.net>

* Syncs distro customizations with Karaf 4.3.7 * Resolves app runbundles for the new dependencies For release notes, see: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311140&version=12351181 This fixes warnings when starting the runtime with Java 17 (#1316). Signed-off-by: Wouter Born <github@maindrain.net>

openhab-bot · 2022-05-15T22:50:31Z

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/java-17/135948/2

openhab-bot · 2022-05-31T13:43:52Z

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/building-on-linux-vs-windows/136338/2

J-N-K · 2022-06-01T11:32:20Z

Regarding the Nashorn add-on: I think this should be added because otherwise a lot of code will need changing.

florian-h05 · 2022-06-04T10:51:22Z

Regarding Java 17, do you know if the automatic file reloading of the JS Scripting add-on is working?

I am asking, because yesterday someone opened an issue on openhab-js and had problems with files not loading on Java 17: openhab/openhab-js#130.

J-N-K · 2022-06-06T10:15:28Z

The reason is that Nashorn is missing on Java 17:

The ScriptFileWatcher checks if an engine is available for the type js before it loads a file. The subclass JSScriptFileWatcher (watching automation/js) overloads the createAndLoad method, so after the super class found out that the script type is supported, it'll use the Graal Engine to process the script.

On Java 11 this works, because Nashorn is available. On Java 17 Nashorn is not available, so the script type js is not registered and the createAndLoad method is never called. I'll provide a fix for that.

openhab-bot · 2022-09-11T11:48:35Z

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/send-command-to-serial-port-and-receive-a-answer/138672/64

openhab-bot · 2022-12-20T22:51:50Z

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-0-snapshot-discussion/142322/22

wborn · 2023-03-20T21:07:48Z

Everything is done now! 🥳

openhab-bot · 2023-08-25T19:45:06Z

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh3-4-oh4-0-2/148900/20

wborn added the enhancement An enhancement or new feature label Sep 19, 2021

wborn pinned this issue Sep 19, 2021

MDAR mentioned this issue Sep 20, 2021

DietPi-Software | openHAB MichaIng/DietPi#3857

Closed

wborn mentioned this issue Sep 26, 2021

GraalVM JavaScript replaces Nashorn, breaking Blockly and existing Nashorn rules openhab/openhab-core#2433

Closed

wborn mentioned this issue Feb 19, 2022

Upgrade Xtext/Xtend to 2.26.0, LSP4J to 0.12.0 openhab/openhab-core#2786

Merged

wborn added this to In Progress in openHAB 3.4 Issue Tracking Feb 20, 2022

wborn mentioned this issue Apr 27, 2022

Upgrade to Karaf 4.3.7 #1389

Merged

J-N-K mentioned this issue Dec 16, 2022

OH4 Tasks openhab/openhab-core#3230

Closed

5 tasks

wborn removed this from In Progress in openHAB 3.4 Issue Tracking Dec 19, 2022

wborn mentioned this issue Mar 12, 2023

Introduce a profile for the generic SCRIPT transformation openhab/openhab-core#3292

Merged

wborn closed this as completed Mar 20, 2023

wborn unpinned this issue Mar 20, 2023

wborn mentioned this issue Sep 19, 2023

Add support for running openHAB with Java 21 #1590

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for running openHAB with Java 17 #1316

Add support for running openHAB with Java 17 #1316

wborn commented Sep 19, 2021 •

edited

openhab-bot commented Sep 19, 2021

wborn commented Sep 19, 2021 •

edited

J-N-K commented Jan 4, 2022

Flole998 commented Feb 12, 2022

wborn commented Feb 20, 2022

wborn commented Feb 20, 2022

J-N-K commented Feb 20, 2022

wborn commented Apr 2, 2022

J-N-K commented Apr 3, 2022 •

edited

wborn commented Apr 3, 2022

J-N-K commented Apr 3, 2022

openhab-bot commented May 15, 2022

openhab-bot commented May 31, 2022

J-N-K commented Jun 1, 2022

florian-h05 commented Jun 4, 2022

J-N-K commented Jun 6, 2022

openhab-bot commented Sep 11, 2022

openhab-bot commented Dec 20, 2022

wborn commented Mar 20, 2023

openhab-bot commented Aug 25, 2023

Add support for running openHAB with Java 17 #1316

Add support for running openHAB with Java 17 #1316

Comments

wborn commented Sep 19, 2021 • edited

openhab-bot commented Sep 19, 2021

wborn commented Sep 19, 2021 • edited

J-N-K commented Jan 4, 2022

Flole998 commented Feb 12, 2022

wborn commented Feb 20, 2022

wborn commented Feb 20, 2022

J-N-K commented Feb 20, 2022

wborn commented Apr 2, 2022

J-N-K commented Apr 3, 2022 • edited

wborn commented Apr 3, 2022

J-N-K commented Apr 3, 2022

openhab-bot commented May 15, 2022

openhab-bot commented May 31, 2022

J-N-K commented Jun 1, 2022

florian-h05 commented Jun 4, 2022

J-N-K commented Jun 6, 2022

openhab-bot commented Sep 11, 2022

openhab-bot commented Dec 20, 2022

wborn commented Mar 20, 2023

openhab-bot commented Aug 25, 2023

wborn commented Sep 19, 2021 •

edited

wborn commented Sep 19, 2021 •

edited

J-N-K commented Apr 3, 2022 •

edited