Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shelly] Shelly TRV: decimal place of target temperature is cut off #16709

Closed
Larsen-Locke opened this issue May 1, 2024 · 2 comments · Fixed by #16746
Closed

[shelly] Shelly TRV: decimal place of target temperature is cut off #16709

Larsen-Locke opened this issue May 1, 2024 · 2 comments · Fixed by #16746
Assignees
Labels
bug An unexpected problem or unintended behavior of an add-on PR pending There is a pull request for resolving the issue

Comments

@Larsen-Locke
Copy link

Larsen-Locke commented May 1, 2024

Shelly TRV: when you set a target temperature (e.g. 20.5) in openhab the decimal place is cut off by the binding so that the Shelly TRV only receives the integer (22). You see in the following log in line1 that the target is set to 22.5. In line2 it's truncated to 22. In line3 it becomes 22.0

LOG:

2024-04-27 16:06:58.809 [DEBUG] [y.internal.handler.ShellyBaseHandler] - shellytrv: Set temperature to 22.5
2024-04-27 16:06:58.809 [TRACE] [shelly.internal.api.ShellyHttpClient] - shellytrv: HTTP GET http://192.168.1.94/thermostat/0?target_t_enabled=1&target_t=22
2024-04-27 16:07:00.666 [TRACE] [shelly.internal.api.ShellyHttpClient] - shellytrv: HTTP Response 200: {"pos":0.0,"target_t":{"enabled":true,"value":22.0,"value_op":8.0,"units":"C"},"tmp":{"value":21.2,"units":"C","is_valid":true},"schedule":false,"schedule_profile":1,"boost_minutes":0,"window_open":false}

Your Environment

openhab 4.2 M2
bug is in binding 4.2dev and 4.2M2

@Larsen-Locke Larsen-Locke added the bug An unexpected problem or unintended behavior of an add-on label May 1, 2024
@Larsen-Locke Larsen-Locke changed the title [shelly] Shelly TRV: decimal place of target temperature is cut off when you set a target temperature (e.g. 20.5) in openhab the decimal place is cut off by the binding so that the Shelly TRV only receives the integer (22). You see in the following log in line1 that the target is set to 22.5. In line2 it's truncated to 22. In line3 it becomes 22.0 LOG: 2024-04-27 16:06:58.809 [DEBUG] [y.internal.handler.ShellyBaseHandler] - shellytrv: Set temperature to 22.5 2024-04-27 16:06:58.809 [TRACE] [shelly.internal.api.ShellyHttpClient] - shellytrv: HTTP GET http://192.168.1.94/thermostat/0?target_t_enabled=1&target_t=22 2024-04-27 16:07:00.666 [TRACE] [shelly.internal.api.ShellyHttpClient] - shellytrv: HTTP Response 200: {"pos":0.0,"target_t":{"enabled":true,"value":22.0,"value_op":8.0,"units":"C"},"tmp":{"value":21.2,"units":"C","is_valid":true},"schedule":false,"schedule_profile":1,"boost_minutes":0,"window_open":false} [shelly] Shelly TRV: decimal place of target temperature is cut off May 1, 2024
@markus7017 markus7017 self-assigned this May 11, 2024
@markus7017
Copy link
Contributor

@Larsen-Locke
Copy link
Author

I tested the TRV with your snapshot and it's running perfectly: Both ways work with full and half-values.

@markus7017 markus7017 added the PR pending There is a pull request for resolving the issue label May 27, 2024
lsiepel pushed a commit that referenced this issue May 28, 2024
…V set temp (#16746)

* fixes ##16736, #16734, #16542, #16709, #16735

Signed-off-by: Markus Michels <markus7017@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on PR pending There is a pull request for resolving the issue
Projects
None yet
3 participants