Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicts with the Prisma Extension #55

Open
MPiccinato opened this issue Aug 10, 2023 · 5 comments
Open

Conflicts with the Prisma Extension #55

MPiccinato opened this issue Aug 10, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@MPiccinato
Copy link

When using this extension along with the Prisma extension, Prisma syntax highlighting breaks, disabling this extension and it works again. I am unsure if this is an issue with this extension or the Prisma extension, but adding this extension into the mix definitely causes .prisma highlighting to break.

@rhamzeh rhamzeh added the bug Something isn't working label Aug 10, 2023
@aaguiarz
Copy link
Member

Thanks @MPiccinato, we'll take a look

@d-jeffery
Copy link
Contributor

@MPiccinato Would you mind sharing a screenshot of what the Prisma highlighting looks like when broken?

@MPiccinato
Copy link
Author

I should have done that in the first place!

Working
Screenshot 2023-08-10 at 3 04 24 PM

Broken
Screenshot 2023-08-10 at 3 05 19 PM

@d-jeffery
Copy link
Contributor

d-jeffery commented Aug 10, 2023

Cool - thanks for that!

I believe it's our fallback color scheme. When we are targeting any file that isn't .openfga or .fga we fall back to Dark (Visual Studio) for all other file extensions while using OpenFGA Dark theme.

If you change your theme to Dark (Visual Studio) whether or not you're using our plugin, the color scheme looks broken cause there is minimal highlights.

Tried this myself without our extension installed. Below is a comparison, with the extension uninstalled, showing difference between Dark (Visual Studio) and Dark Modern:

image
image

Will bring this to the team, but in the mean time, I suggest using a theme that looks satisfactory with both languages.

@MPiccinato
Copy link
Author

@d-jeffery Amazing! Thank you for the explanation and taking a look at it. Got it working now. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants