Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Axios usage in modules/FacetedSearchSettingsModule.ts to REST Module #2624

Open
edalex-ian opened this issue Dec 22, 2020 · 0 comments
Labels
Edalex RDA Edalex Tech debt Anything to with the health of the code base

Comments

@edalex-ian
Copy link
Member

Is your feature request related to a problem? Please describe.

modules/FacetedSearchSettingsModule.ts has a number of direct Axios usages which should be moved to the REST module (oeq-ts-rest-api).

Describe the solution you'd like

  • Create FacetedSearchSettings.ts in REST Module with the functions:
    • getFacets
    • batchUpdateOrAddFacets - NOTE: FacetWithFlags however should not be used outside of the front-end
    • batchDeleteFacets
  • Update FacetedSearchSettingsModule.ts to use the REST Module functions

Additional context

There are a number of modules that require this, each will have its own ticket.

There is some interesting overlap here with the batch operations also found in the SearchFilterSettingsModule. Whether some consideration needs to be given to that in the REST module I'm not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edalex RDA Edalex Tech debt Anything to with the health of the code base
Projects
None yet
Development

No branches or pull requests

1 participant