Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edx-platform required checks #34789

Open
kdmccormick opened this issue Mar 28, 2024 · 6 comments
Open

Fix edx-platform required checks #34789

kdmccormick opened this issue Mar 28, 2024 · 6 comments
Assignees

Comments

@kdmccormick
Copy link
Member

kdmccormick commented Mar 28, 2024

Repository

axim-engineering

Urgency

Low (2 weeks)

Requested Change

The set of required checks on edx-platform and/or the "unit tests successful" check itself need to be fixed, although we're not exactly sure how yet.

They don't currently enforce that all unit tests pass, as the Unit tests successful check seems to be getting skipped.

More details:

We have disabled Auto-merge on edx-platform because of this. As part of resolving this ticket, please re-enable it.

Reasoning

.

@openedx-workflow-automation
Copy link

Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer.

@sarina
Copy link
Contributor

sarina commented Apr 4, 2024

@kdmccormick @e0d are either of you taking this, or is this a backlog eng item?

@kdmccormick
Copy link
Member Author

I am not, and I doubt Ed is, so it's in the backlog, although I'd vouch for it to be high up in the backlog.

@sarina
Copy link
Contributor

sarina commented Apr 4, 2024

I'm just wondering if it's an on-call ticket or not. I don't know how to address this.

@kdmccormick kdmccormick changed the title [GH Request] Fix edx-platform required checks Fix edx-platform required checks Apr 4, 2024
@kdmccormick
Copy link
Member Author

Fair, I guess it's more edx-platform maintenance than on-call work.

@feanil and I are next up in the on-call queue, so I figure whichever one of us has time first can pick it up.

@kdmccormick
Copy link
Member Author

kdmccormick commented May 6, 2024

@feanil LMK here when you switch us over to github hosted unit test runners. I think it should make these required checks much easier to manage. I'm reeealllllyyyy looking forward to being able to auto-merge edx-platform PRs again 😄

@kdmccormick kdmccormick transferred this issue from openedx/axim-engineering May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

3 participants