Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure JS tests don't fail silently #34550

Open
brian-smith-tcril opened this issue Apr 19, 2024 · 0 comments
Open

Ensure JS tests don't fail silently #34550

brian-smith-tcril opened this issue Apr 19, 2024 · 0 comments

Comments

@brian-smith-tcril
Copy link
Contributor

While working on the node 18 upgrade, I was able to get the JS tests CI check to pass with the application in a non-working state. After a bit of investigation, I found there were a couple test suites that weren't running due to webpack build issues. We should ensure that a test suite that doesn't run due to a build issue fails CI as opposed to silently passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant