Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPR]: Neo4J Support #34342

Closed
dianakhuang opened this issue Mar 7, 2024 · 11 comments
Closed

[DEPR]: Neo4J Support #34342

dianakhuang opened this issue Mar 7, 2024 · 11 comments
Assignees
Labels
depr Proposal for deprecation & removal per OEP-21

Comments

@dianakhuang
Copy link
Contributor

dianakhuang commented Mar 7, 2024

Proposal Date

2024-03-07

Target Ticket Acceptance Date

2024-03-21

Earliest Open edX Named Release Without This Functionality

Sumac 2024-10

Rationale

We would like to take out neo4j support from edx-platform and remove it as a dependency from edx-platform. We believe this library and its usage is underused and not particularly valuable as many operators have switched to searching course data in other types of data stores.

Removal

Removal of https://github.com/openedx/edx-platform/tree/master/cms/djangoapps/coursegraph and the neo4j library from edx-platform. If anyone wants to keep this functionality, a separate plugin can be created.

Replacement

We do not have a replacement.

Discuss thread: https://discuss.openedx.org/t/deprecation-removal-coursegraph-neo4j-support/12480

@github-actions github-actions bot added the depr Proposal for deprecation & removal per OEP-21 label Mar 7, 2024
@bmtcril
Copy link
Contributor

bmtcril commented Mar 7, 2024

For folks looking for a replacement, Aspects we've emulated much of what Coursegraph does in ClickHouse via openedx-event-sink-clickhouse (which currently has a DEPR, but just to consolidate the code with other Aspects plugins in platform-plugin-aspects). It's not 1:1, but can help answer some of the same questions.

@qasimgulzar
Copy link
Contributor

Assign it to me

qasimgulzar added a commit to qasimgulzar/edx-platform that referenced this issue Mar 25, 2024
qasimgulzar added a commit to qasimgulzar/edx-platform that referenced this issue Mar 25, 2024
qasimgulzar added a commit to qasimgulzar/edx-platform that referenced this issue Mar 25, 2024
qasimgulzar added a commit to qasimgulzar/edx-platform that referenced this issue Mar 25, 2024
@qasimgulzar
Copy link
Contributor

Here I have created a PR Please review

@qasimgulzar
Copy link
Contributor

@bmtcril could you please review my PR?

@bmtcril
Copy link
Contributor

bmtcril commented Mar 25, 2024

According to @dianakhuang 's DEPR this is supposed to remain through Sumac. I assume to let the community have one release of warning before the removal. @qasimgulzar are you proposing to merge this sooner?

qasimgulzar added a commit to qasimgulzar/edx-platform that referenced this issue Mar 26, 2024
@qasimgulzar
Copy link
Contributor

As of it doesn't seems like openedx itself consuming neo4j. I believe it is safe to merge.

@bmtcril
Copy link
Contributor

bmtcril commented Mar 29, 2024

Hi @qasimgulzar I'm saying that merging the PR now goes against the DEPR announcement and the PR description since it which we can't allow since "Earliest Open edX Named Release Without This Functionality" would actually be Redwood. I'm not against removing it before Redwood, but we should follow the process and update the DEPR and re-announce the new dates to make sure that anyone using it will know that they need to make adjustments sooner.

@jristau1984
Copy link
Contributor

I don't personally think this would be prudent given the small amount of time before Redwood cut, but that is just my opinion.

@qasimgulzar
Copy link
Contributor

I think it make sense to give it more time, I can make another PR to add deprecation warning for this app before removing.

@qasimgulzar
Copy link
Contributor

Here I have created a new PR to add warning message.

@dianakhuang dianakhuang self-assigned this Apr 4, 2024
@feanil feanil assigned feanil and unassigned dianakhuang May 2, 2024
qasimgulzar added a commit to qasimgulzar/edx-platform that referenced this issue May 15, 2024
qasimgulzar added a commit to qasimgulzar/edx-platform that referenced this issue May 17, 2024
qasimgulzar added a commit to qasimgulzar/edx-platform that referenced this issue May 17, 2024
feanil added a commit that referenced this issue May 28, 2024
@feanil
Copy link
Contributor

feanil commented May 28, 2024

The removal has landed on master of edx-platform via #34417

@feanil feanil closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depr Proposal for deprecation & removal per OEP-21
Projects
Status: Removed
Development

No branches or pull requests

5 participants