Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find an upgrade path from pyjwkest to PyJWT #31927

Closed
timmc-edx opened this issue Mar 14, 2023 · 4 comments
Closed

Find an upgrade path from pyjwkest to PyJWT #31927

timmc-edx opened this issue Mar 14, 2023 · 4 comments
Assignees

Comments

@timmc-edx
Copy link
Contributor

timmc-edx commented Mar 14, 2023

We're trying to discontinue use of pyjwkest: openedx/edx-drf-extensions#290 PyJWT looks like the best candidate, but the RSA key format requirements are stricter, so we wouldn't be able to use our current keys (at least, if they look like the keys the unit tests use).

Partial PR, showing the changes that would be required: #31829

Look into upgrade paths. Some options:

  • Make our keys forward-compatible
  • Provision multiple keys and select which one to use based on which library is present
  • Figure out how to convert the keys on the fly at startup
@timmc-edx timmc-edx self-assigned this Mar 14, 2023
@timmc-edx
Copy link
Contributor Author

Suggested a path forward here: #31829 (comment)

@robrap
Copy link
Contributor

robrap commented Mar 15, 2023

Adding @iamsobanjaved so everyone is participating in this ticket.

@robrap
Copy link
Contributor

robrap commented Mar 15, 2023

Would there be a simple way to try all keys with all libraries, and succeed if anything succeeds?

@timmc-edx
Copy link
Contributor Author

Decision: We're going to make the keys forward-compatible before making the code change. This might mean adjusting the existing keys or doing a key rotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants