Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

EDXAPP_DJFS needs to be in YAML style? #1761

Conversation

usernamenumber
Copy link

Perhaps I'm just misunderstanding something, but the bash-style variable here appears to be incorrect, and it definitely caused an error for me, which went away after applying this change. See this comment for details on the error.

@openedx-webhooks
Copy link

Thanks for the pull request, @usernamenumber! I've created OSPR-327 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ('this must be merged by XX date', and why that is)
  • partner information ('this is a course on edx.org')
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the Github pull request interface. As a reminder, our process documentation is here.

We can't start reviewing your pull request until you've added yourself to the AUTHORS file. Please see the CONTRIBUTING file for more information.

@e0d
Copy link
Contributor

e0d commented Dec 30, 2014

The $ variable is an ansible variable that is supported in the version we specify in requirements.txt. What version of ansible were you testing with?

We have plan to upgrade ansible, but there are some breaking changes in the new version that we need to navigate.

@usernamenumber
Copy link
Author

Ah, thanks for the clarification. I'm currently running 1.8.2, but it's possible I've upgraded since my last attempt, and unfortunately I don't have everything I would need to try again right now.

@e0d
Copy link
Contributor

e0d commented Dec 30, 2014

Yeah, unfortunately we are stuck on 1.5.5 until we can resolve some issues. Either in our code or by getting this, http://github.com/ansible/ansible/issues/9362, fixed.

I'm going to close this as we will be removing all $vars via a separate effort.

@e0d e0d removed the needs triage label Dec 30, 2014
@e0d e0d closed this Dec 30, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants