Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronize with scikit-build #637

Merged
merged 1 commit into from Apr 7, 2022
Merged

Synchronize with scikit-build #637

merged 1 commit into from Apr 7, 2022

Conversation

orbisvicis
Copy link

@orbisvicis orbisvicis commented Mar 21, 2022

scikit-build commit 94089992b353ea3e4b4c2f118ea1987ca54ecbb8:
skbuild/setuptools_wrap.py:_classify_installed_files
cmake_install_dir -> _cmake_install_dir

scikit-build commit 94089992b353ea3e4b4c2f118ea1987ca54ecbb8:
skbuild/setuptools_wrap.py:_classify_installed_files
    cmake_install_dir -> _cmake_install_dir

This allows tracking scikit-build versions >= 0.13.2. The dependencies
file has been updated.
@orbisvicis
Copy link
Author

This is for the upcoming 0.13.2 release of scikit-build, and the dependency file (pyproject.toml) has been updated. Pinning a minimum version of scikit-build allows following development, i.e. support for new OSs.

Copy link
Contributor

@asenyaev asenyaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will pin versions for all dependencies in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants