Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX pip install fails @ Python 3.11 & Darwin #947

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from
Open

FIX pip install fails @ Python 3.11 & Darwin #947

wants to merge 1 commit into from
+1 −1

Conversation

ananich
Copy link

@ananich ananich commented Jan 7, 2024

Fixes #946

@jfracon
Copy link

jfracon commented Apr 22, 2024

Is there any update on this? I think @ananich commit will solve the issue and also allow working with Python 3.12. Numpy 1.22.2 is not compatible with Python 3.12 due to the deprecation and removal of imp ( AttributeError: module 'pkgutil' has no attribute 'ImpImporter'. Did you mean: 'zipimporter'?)

jfracon
jfracon approved these changes Apr 22, 2024
View reviewed changes
Copy link

@jfracon jfracon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will allow working with Python 3.12. This is now not possible due to the deprecation and removal of the imp module which is used by Numpy versions below 1.26.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfracon jfracon jfracon approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pip install fails @ Python 3.11 & Darwin
2 participants
@ananich @jfracon