writeCon: no need to wrap os.Write error #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The errors returned from os are usually descriptive enough (i.e. they contain the file name and the failed operation). Fixes: bb3d708 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
thaJeztah
approved these changes
Sep 9, 2021
Comment on lines
391
to
394
| if err != nil { | ||
| return &os.PathError{Op: "write", Path: fpath, Err: err} | ||
| return err | ||
| } | ||
| return nil |
There was a problem hiding this comment.
Surprised the linter didn't complain that this could just return err (which could be nil, or not).
I'm ok with the current version as the linter is ok with it (and it may be somewhat clearer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The errors returned from os are usually descriptive enough
(i.e. they contain the file name and the failed operation).
Fixes: bb3d708