(Context).get: speedup #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmt.Sprintf is slow. Let's use string concatenation instead, and avoid looking up level label twice. Benchmark shows 3x improvement in performance, and less allocations. name old time/op new time/op delta ContextGet-4 277ns ± 1% 93ns ± 1% -66.55% (p=0.016 n=4+5) name old alloc/op new alloc/op delta ContextGet-4 128B ± 0% 64B ± 0% ~ (p=0.079 n=4+5) name old allocs/op new allocs/op delta ContextGet-4 5.00 ± 0% 1.00 ± 0% ~ (p=0.079 n=4+5) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
LGTM |
rhatdan
approved these changes
Sep 9, 2021
rhatdan
approved these changes
Sep 9, 2021
It's not, but the fix is trivial, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fmt.Sprintfis slow. Let's use string concatenation instead, and avoidlooking up level label twice.
Benchmark shows 3x improvement in performance, and less allocations.
Signed-off-by: Kir Kolyshkin kolyshkin@gmail.com