Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement c/r error reporting #3711

Closed
kolyshkin opened this issue Jan 27, 2023 · 3 comments · Fixed by #3816
Closed

Implement c/r error reporting #3711

kolyshkin opened this issue Jan 27, 2023 · 3 comments · Fixed by #3816

Comments

@kolyshkin
Copy link
Contributor

Currently, when checkpoint or restore fails, runc diagnostics is inadequate, as the error itself is hiding in criu logs. This is why we have something like

		grep -B 5 Error "$workdir"/*.log ./image-dir/*.log || true

all across the https://github.com/opencontainers/runc/blob/main/tests/integration/checkpoint.bats

Perhaps we can implement something like this in runc itself, so it will show something useful in case of error.

@danishprakash
Copy link
Contributor

@kolyshkin mind If I take a look at this?

@kolyshkin
Copy link
Contributor Author

Fixed by #3816

@kolyshkin
Copy link
Contributor Author

Somehow I forgot the last step, here it is: #4251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants