[release-1.1] configs/validate: looser validation for RDT #3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kolyshkin @AkihiroSuda please take a look |
AkihiroSuda
previously approved these changes
Mar 8, 2022
dqminh
previously approved these changes
Mar 8, 2022
|
I'm going to try to use github feature to rebase this. If this will work, I'll enable this feature for the main branch as well. |
|
Alas, the feature is not working the way I hoped for ( |
|
@dqminh @AkihiroSuda you have to re-LGTM; my apologies. |
AkihiroSuda
previously approved these changes
Mar 9, 2022
@kolyshkin I guess we need your Signed-off-by line too |
kolyshkin
force-pushed
the
backports/rdt
branch
from
4316e83
to
094e402
Compare
Added. |
AkihiroSuda
approved these changes
Mar 10, 2022
Don't require CAT or MBA because we don't detect those correctly (we don't support L2 or L3DATA/L3CODE for example, and in the future possibly even more). With plain "ClosId mode" we don't really care: we assign the container to a pre-configured CLOS without trying to do anything smarter. Moreover, this was a duplicate/redundant check anyway, as for CAT and MBA there is another specific sanity check that is done if L3 or MB is specified in the config. Signed-off-by: Markus Lehtonen <markus.lehtonen@intel.com> (cherry picked from commit 1d5c331) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
backports/rdt
branch
from
094e402
to
ee7ba6c
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3382.
Don't require CAT or MBA because we don't detect those correctly (we
don't support L2 or L3DATA/L3CODE for example, and in the future
possibly even more). With plain "ClosId mode" we don't really care: we
assign the container to a pre-configured CLOS without trying to do
anything smarter.
Moreover, this was a duplicate/redundant check anyway, as for CAT and
MBA there is another specific sanity check that is done if L3 or MB
is specified in the config.
Signed-off-by: Markus Lehtonen markus.lehtonen@intel.com
(cherry picked from commit 1d5c331)