Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: clarify image source annotation use for repos with multiple Dockerfiles #886

Open
petermetz opened this issue Dec 9, 2021 · 0 comments

Comments

@petermetz
Copy link

petermetz commented Dec 9, 2021

From the spec:

org.opencontainers.image.source URL to get source code for building the image (string)

I was wondering how I should set this for multiple images that are all sharing the same git repository (a NodeJS monorepo):
a) All images point to the root of the git repo
b) All images specify the specific sub-folder path within the link so that people who click on it are taken there directly and won't have to look for it manually (we have a repo with 10+ Dockerfiles that aren't trivial to find unless you are already familiar with the directory structure of mono-repositories in general)

To me, option b) sounds better because it's more convenient to the user, but I wanted to double check if this is what the spec authors would've expected and also if there would be some interest in adding some additional clarifications to the spec regarding the preferred/recommended approach (if there is one)

The give more context, here is a (partial) list of container image definitions in the Hyperledger Cactus repo that I'm a maintainer of:

Screenshot from 2021-12-09 09-54-59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant