Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create duplicate memberships when merging accounts #4648

Open
Betree opened this issue Sep 8, 2021 · 1 comment · May be fixed by opencollective/opencollective-api#9927
Open

Do not create duplicate memberships when merging accounts #4648

Betree opened this issue Sep 8, 2021 · 1 comment · May be fixed by opencollective/opencollective-api#9927
Assignees
@Betree
Labels
api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) complexity → simple enhancement
Milestone
Support & Operations

Comments

@Betree
Copy link
Member

Betree commented Sep 8, 2021

Not a big issue and easy to fix manually, but the mergeAccounts (root-only) feature can end up creating duplicate memberships. If you merge two users, and they're both an admin of a collective, you will end up with two ADMIN memberships to the same collective.

Expected behavior

When moving members, if an entry already exists for this CollectiveId/MemberId/role/TierId, (soft) delete the membership rather than moving it.
@Betree Betree added complexity → simple api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) enhancement labels Sep 8, 2021
@BenJam BenJam mentioned this issue Aug 25, 2022
Open
7 tasks
@BenJam BenJam changed the title Merge accounts: better strategy for members Do not create duplicate memberships when merging accounts Aug 25, 2022
@znarf znarf added this to the Support & Operations milestone Sep 15, 2022
@Betree Betree mentioned this issue Oct 23, 2023
Merged
@Betree
Copy link
Member Author

Betree commented Mar 11, 2024

Would be great to look into this one as we're going to merge a lot of accounts in the coming weeks.

@Betree Betree self-assigned this Mar 11, 2024
@Betree Betree linked a pull request Mar 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Betree Betree

Labels
api Issues that require some work on the API (https://github.com/opencollective/opencollective-api) complexity → simple enhancement
Projects
None yet
Milestone
Support & Operations
Development

Successfully merging a pull request may close this issue.

RootActions: handle duplicates when merging members opencollective/opencollective-api
2 participants
@znarf @Betree