Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{:ssl_closed, _} leaking from Hackney into oc_reporter #4

Closed
astutecat opened this issue Nov 13, 2019 · 2 comments
Closed

{:ssl_closed, _} leaking from Hackney into oc_reporter #4

astutecat opened this issue Nov 13, 2019 · 2 comments

Comments

@astutecat
Copy link

astutecat commented Nov 13, 2019

We've noticed that when using opencensus_honeycomb on our system that we've been getting the following happening:

** (FunctionClauseError) no function clause matching in :oc_reporter.handle_info/2 Nov 06 11:40:42 ...compute.internal ...[4827]: (opencensus) /.../oc_reporter.erl:105: :oc_reporter.handle_info({:ssl_closed, {:sslsocket, {:gen_tcp, #Port<0.17 519>, :tls_connection, :undefined}, [#PID<0.25634.163>, #PID<0.25891.163>]}}, {:state, [{Opencensus.Honeycomb.Reporter, :ok}], 1500, #Reference<0.4075178422.1500512257.140826>})

We found this of particular concern because at points this crash was happening frequently enough that it would take down the VM.

We did an investigation and found the following open issue: benoitc/hackney#464 and eventually, we got to this useful piece of information: benoitc/hackney#464 (comment)

I believe that the same issue that was affecting oc_google_reporter may also be affecting opencensus_honeycomb - I've got a code change that I hope will resolve it, but I've not been able to reproduce it to test it yet.

@garthk
Copy link
Collaborator

garthk commented Dec 8, 2019

Nicely tracked down. Sorry I didn't spot this earlier; thanks for chasing it up within cooee of @tsloughter.

@garthk
Copy link
Collaborator

garthk commented Dec 8, 2019

Published v0.2.1.

@garthk garthk closed this as completed Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants