New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Php] Convert boolean value for query string (Configuration) #12385
Merged
wing328
merged 10 commits into
OpenAPITools:master
from
ksvirkou-hubspot:feature/queryStringBoolValue
May 25, 2022
Merged
[Php] Convert boolean value for query string (Configuration) #12385
wing328
merged 10 commits into
OpenAPITools:master
from
ksvirkou-hubspot:feature/queryStringBoolValue
May 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update master
merge master
merge master
merge master
merge master
merge master
ksvirkou-hubspot
changed the title
Feature/query string bool value
[Php] Convert boolean value for query string
May 17, 2022
@jebentier , @dkarlovi , @mandrean , @jfastnacht , @ybelenko , @renepardon |
5 tasks
ksvirkou-hubspot
changed the title
[Php] Convert boolean value for query string
[Php] Convert boolean value for query string (Configuration)
May 23, 2022
I'm ok with it. If no further feedback/question for this PR, I'll merge it tomorrow. Thanks for the PR. |
ybelenko
approved these changes
May 25, 2022
Just checked locally under php 8.1.6: vendor/bin/phpunit tests/ObjectSerializerTest.php
PHPUnit 9.5.20
................................................................. 65 / 65 (100%)
Time: 00:00.087, Memory: 6.00 MB
OK (65 tests, 76 assertions) The code looks fine. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates an property in configuration "booleanFormatForQueryString"
User can set the format for conversation of boolean to the query string
user can set int (param=1 or param=0) or string (param=true or param=false)
int is default format because guzzle/psr7 converts boolean to int (param=1 or param=0)
example of use
it will fix #11683
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.