New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Inline model resolver] various improvements #12293
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
added
Breaking change (without fallback)
Enhancement: General
Inline Schema Handling
Schema contains a complex schema in items/additionalProperties/allOf/oneOf/anyOf
labels
May 3, 2022
@impl I wonder if you can review this change when you've time as you've filed a similar change. Thank you. |
4 tasks
wing328
commented
May 9, 2022
// TODO revise the commented test below as oneOf is no longer defined inline | ||
//but instead defined using $ref with the new inline model resolver in 6.x | ||
//Assert.assertEquals(operation.imports, Sets.newHashSet("Cat", "Dog")); | ||
Assert.assertEquals(operation.imports, Sets.newHashSet("InlineRequest")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TiFu FYI. We've updated the inlined resolver to create a separate model/schema for all inline schemas(including oneOf/allOf) in the request bodies.
This was referenced May 10, 2022
sorin-florea
added a commit
to sorin-florea/openapi-generator
that referenced
this pull request
May 10, 2022
…-param-explode * origin/master: Add martindelille to code owners (OpenAPITools#12328) add tests to set httpUserAgent in r client (OpenAPITools#12321) better error messages for oneOf in java okhttp-gson (OpenAPITools#12311) [Inline model resolver] various improvements (OpenAPITools#12293)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaking change (without fallback)
Enhancement: General
Inline Schema Handling
Schema contains a complex schema in items/additionalProperties/allOf/oneOf/anyOf
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
cc https://github.com/orgs/OpenAPITools/teams/generator-core-team