Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C][Client] Eliminate compiler warnings #12260

Merged
merged 1 commit into from Apr 30, 2022

Conversation

ityuhui
Copy link
Contributor

@ityuhui ityuhui commented Apr 28, 2022

If we call apiClient_invoke with some const char * as parameters of the function, ( the complete source code is https://github.com/kubernetes-client/c/blob/master/kubernetes/src/generic.c) then there are some warnings while compiling the C client library.

src/generic.c:57:38: warning: passing argument 2 of ‘apiClient_invoke’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
     apiClient_invoke(client->client, path, queryParameters, headerParameters, formParameters, headerType, contentType, body, method);
                                      ^~~~
In file included from src/generic.c:1:0:
src/../include/apiClient.h:43:6: note: expected ‘char *’ but argument is of type ‘const char *’
 void apiClient_invoke(apiClient_t *apiClient,char* operationParameter, list_t *queryParameters, list_t *headerParameters, list_t *formParameters,list_t *headerType,list_t *contentType, char *bodyParameters, char *requestType);

This PR eliminates these compiler warnings.

@wing328 @zhemant @michelealbano

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Copy link
Contributor

@zhemant zhemant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, LGTM!

@wing328
Copy link
Member

wing328 commented Apr 30, 2022

Tested locally and the result is good:

[ 73%] Building C object CMakeFiles/openapi_petstore.dir/model/user.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 80%] Building C object CMakeFiles/openapi_petstore.dir/api/PetAPI.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 86%] Building C object CMakeFiles/openapi_petstore.dir/api/StoreAPI.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[ 93%] Building C object CMakeFiles/openapi_petstore.dir/api/UserAPI.c.o
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[100%] Linking C shared library libopenapi_petstore.so
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)
[100%] Built target openapi_petstore
/usr/bin/cmake: /usr/local/lib/libcurl.so.4: no version information available (required by /usr/bin/cmake)

@wing328 wing328 merged commit 2ca6cf7 into OpenAPITools:master Apr 30, 2022
@ityuhui ityuhui deleted the yh-const-0428 branch May 1, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants