Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aspnetcore] Include appsettings.Development.json #12217

Merged
merged 2 commits into from Apr 26, 2022

Conversation

DanielHabenicht
Copy link
Contributor

@DanielHabenicht DanielHabenicht commented Apr 23, 2022

Previously the file was not used and not part of the output although it already exists as template

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

previously the file was not used and not part of the output although already existing as template
@DanielHabenicht DanielHabenicht changed the title Include appsettings.Development.json [aspnetcore] Include appsettings.Development.json Apr 23, 2022
@DanielHabenicht DanielHabenicht marked this pull request as ready for review April 23, 2022 17:59
@DanielHabenicht
Copy link
Contributor Author

@mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) ready for review from my side

@wing328
Copy link
Member

wing328 commented Apr 26, 2022

@DanielHabenicht thanks for the PR, which looks good to me.

@wing328 wing328 merged commit 6b49d19 into OpenAPITools:master Apr 26, 2022
@wing328 wing328 added this to the 6.0.0 milestone Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants