Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp-restsdk] Change build folder structure to match include folder structure in installed client #11487

Merged
merged 2 commits into from Feb 24, 2022

Conversation

srgbtl
Copy link
Contributor

@srgbtl srgbtl commented Feb 1, 2022

Fixes #11103:

  • Change source code directory structure for cpprestsdk generated code
  • Change include header file order: standard C++ headers are included after cpprestsdk/boost headers.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd @mvistein

@srgbtl srgbtl marked this pull request as draft February 1, 2022 16:59
@srgbtl srgbtl marked this pull request as ready for review February 1, 2022 17:15
@mvistein
Copy link
Contributor

mvistein commented Feb 8, 2022

This PR looks good to me and seems to solve my issue #11103

@wing328
Copy link
Member

wing328 commented Feb 24, 2022

Tested locally and the result compiles without issues.

@wing328 wing328 merged commit 237706d into OpenAPITools:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][cpp-restsdk] include folder structure in installed client does not match build folder structure
3 participants