Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axios update #130

Closed
Jsherborne92 opened this issue Oct 6, 2022 · 4 comments
Closed

axios update #130

Jsherborne92 opened this issue Oct 6, 2022 · 4 comments

Comments

@Jsherborne92
Copy link

Please update the axios peer dependency to the latest.

@anttiviljami
Copy link
Member

anttiviljami commented Oct 9, 2022

Why? ^0.25.0 is fully compatible with latest. This would just break backwards compatibility

@jazmon
Copy link

jazmon commented Oct 26, 2022

Moro moro! 👀 Just to weigh in, I had to change axios version (to the semver-compatible one).
Axios has released v1 now.

In order to support the latest version, some things have to be fixed.
I ran into the following issue before giving up and downgrading axios:

Update: that does seem to be the only breaking issue for me and it can be fixed in app code with:

axiosConfigDefaults: {
  paramsSerializer: {
    serialize: params => {
      return new URLSearchParams(params).toString();
    },
  },
},

@Riglanto
Copy link

Riglanto commented Nov 3, 2022

Any chance to get at least beta version wit axios 1+? In our case we've been using axios 1+ for some time, then added openapi-client-axios which is superb when working with external apis. We manage to make it work with 1+ and 0.25 in peer dependency leveraging legacy-peer-deps flag, but that leads to problems with prisma (that some deps/post-scripts are not run properly).

Edit:
I found the exact bug that brought me here: axios/axios#4460
It was fixed with axios 0.27.2

@anttiviljami
Copy link
Member

Hi guys! openapi-client-axios@6.0.0 is now out with support for axios v1. 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants